RE: [PATCH v3] cdx: Rename MCDI_LOGGING to CDX_MCDI_LOGGING

From: Gangurde, Abhijit
Date: Mon Jun 12 2023 - 04:10:30 EST


[AMD Official Use Only - General]

> On Tue, Jun 06, 2023 at 07:31:37PM +0530, Abhijit Gangurde wrote:
> > MCDI_LOGGING is too generic considering other MCDI users
> > SFC_MCDI_LOGGING and SFC_SIENA_MCDI_LOGGING. Rename it to
> > CDX_MCDI_LOGGING makes it more domain specific.
> >
> > Also, move CONFIG_CDX_MCDI_LOGGING to header file.
> >
> > Fixes: eb96b740192b ("cdx: add MCDI protocol interface for firmware
> interaction")
> > Signed-off-by: Abhijit Gangurde <abhijit.gangurde@xxxxxxx>
> > Suggested-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Closes:
> https://lore.kernel.org/lkml/CAMuHMdWTCdQagFFANygMgA8D0sWaoGxWv
> 2AjibC3vwSd0UxuRw@xxxxxxxxxxxxxx/
> > ---
> > Changes v2->v3:
> > - Dropped sysfs entry changes from v2
>
> Where is patch 2/2 in this series that moves to use dynamic debugging
> instead of this custom mess?
>
> This shouln't be a config option at all, as no one will be able to
> enable it on a real system.
>

Will send v4 with completely removing custom logging and use the dynamic debugging.

Thanks,
Abhijit