Re: [PATCH net-next] ice: Remove managed memory usage in ice_get_fw_log_cfg()

[Pavan Chebbi]

On Mon, Jun 12, 2023 at 2:14 AM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
>
> There is no need to use managed memory allocation here. The memory is
> released at the end of the function.
>
> You kzalloc()/kfree() to simplify the code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/intel/ice/ice_common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good to me.
Reviewed-by: Pavan Chebbi <pavan.chebbi@xxxxxxxxxxxx>

>
> diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c
> index eb2dc0983776..4b799a5d378a 100644
> --- a/drivers/net/ethernet/intel/ice/ice_common.c
> +++ b/drivers/net/ethernet/intel/ice/ice_common.c
> @@ -834,7 +834,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
>         u16 size;
>
>         size = sizeof(*config) * ICE_AQC_FW_LOG_ID_MAX;
> -       config = devm_kzalloc(ice_hw_to_dev(hw), size, GFP_KERNEL);
> +       config = kzalloc(size, GFP_KERNEL);
>         if (!config)
>                 return -ENOMEM;
>
> @@ -857,7 +857,7 @@ static int ice_get_fw_log_cfg(struct ice_hw *hw)
>                 }
>         }
>
> -       devm_kfree(ice_hw_to_dev(hw), config);
> +       kfree(config);
>
>         return status;
>  }
> --
> 2.34.1
>
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature