Re: [PATCH] fs: Fix comment typo

From: Bagas Sanjaya
Date: Sun Jun 11 2023 - 21:53:25 EST


On 6/12/23 08:41, Bagas Sanjaya wrote:
> On Sun, Jun 11, 2023 at 01:50:34PM -0600, Jonathan Corbet wrote:
>> Bagas Sanjaya <bagasdotme@xxxxxxxxx> writes:
>>
>>> On Sun, Jun 11, 2023 at 08:33:14AM -0400, Shaomin Deng wrote:
>>>> From: Mao Zhu <zhumao001@xxxxxxxxxx>
>>>>
>>>> Delete duplicated word in comment.
>>>
>>> On what function?
>>
>> Bagas, do I *really* have to ask you, yet again, to stop nitpicking our
>> contributors into the ground? It appears I do. So:
>>
>> Bagas, *stop* this. It's a typo patch removing an extraneous word. The
>> changelog is fine. We absolutely do not need you playing changelog cop
>> and harassing contributors over this kind of thing.
>
> OK, thanks for reminding me again.
>
> At the time of reviewing, I had bad feeling that @cdjrlc.com people will
> ignore review comments (I betted due to mail setup problem that prevents
> them from properly repling to mailing lists, which is unfortunate). I
> was nitpicking because the diff context doesn't look clear to me (what
> function name?).
>

And no wonder why several maintainers also highlight this (which prompted
me to review that way):

[1]: https://lore.kernel.org/all/162b5545-7d24-3cf2-9158-3100ef644e03@xxxxxxxxxxxxxxx/
[2]: https://lore.kernel.org/all/3a73cf7f02915891c77dc5a3203dc187f6d91194.camel@xxxxxxxxxxxxxxxxxxxxx/

--
An old man doll... just what I always wanted! - Clara