Re: [PATCH v2 1/2] scsi: ufs: mcq: Fix the incorrect OCS value for the device command

From: Bart Van Assche
Date: Sun Jun 11 2023 - 11:19:12 EST


On 6/11/23 07:49, Stanley Chu wrote:
This patch removes the 'cqe' member from the struct ufs_dev_cmd, as
shown in the code section below. Please let us know if anything else
has been missed. Very appreciated.

diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h
index 9b2d1859f885..602615e6d1bf 100644
--- a/include/ufs/ufshcd.h
+++ b/include/ufs/ufshcd.h
@@ -225,7 +225,6 @@ struct ufs_dev_cmd {
struct mutex lock;
struct completion *complete;
struct ufs_query query;
- struct cq_entry *cqe;
};

I misread the patch. Since the patch looks fine to me after having taken a second look:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>