Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

[Oded Gabbay]

On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar <ttayar@xxxxxxxxx> wrote:
>
> On 09/06/2023 15:06, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > Two functions got added with normal prototypes for debugfs, but not
> > alternative when building without it:
> >
> > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
> >
> > Add stubs for these as well.
> >
> > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Thanks,
> Reviewed-by: Tomer Tayar <ttayar@xxxxxxxxx>

Thanks,
Applied to -fixes.
Oded
>
> > ---
> >   drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> > index d92ba2e30e310..2f027d5a82064 100644
> > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> >   {
> >   }
> >
> > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > +{
> > +     return 0;
> > +}
> > +
> > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > +{
> > +}
> > +
> >   static inline void hl_debugfs_add_device(struct hl_device *hdev)
> >   {
> >   }
>
>