Re: [PATCH v2] hwmon: (oxp-sensors) Add tt_toggle attribute on supported boards

From: kernel test robot
Date: Sat Jun 10 2023 - 19:06:21 EST


Hi Joaquín,

kernel test robot noticed the following build errors:

[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on next-20230609]
[cannot apply to linus/master v6.4-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Joaqu-n-Ignacio-Aramend-a/hwmon-oxp-sensors-Add-tt_toggle-attribute-on-supported-boards/20230611-032531
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link: https://lore.kernel.org/r/20230610192400.80611-2-samsagax%40gmail.com
patch subject: [PATCH v2] hwmon: (oxp-sensors) Add tt_toggle attribute on supported boards
config: x86_64-randconfig-a013-20230611 (https://download.01.org/0day-ci/archive/20230611/202306110659.msus3mCo-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a)
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add groeck-staging https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
git fetch groeck-staging hwmon-next
git checkout groeck-staging/hwmon-next
b4 shazam https://lore.kernel.org/r/20230610192400.80611-2-samsagax@xxxxxxxxx
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306110659.msus3mCo-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/hwmon/oxp-sensors.c:445:10: error: label at end of compound statement: expected statement
default:
^
;
1 error generated.


vim +445 drivers/hwmon/oxp-sensors.c

416
417 /* Initialization logic */
418 static int oxp_platform_probe(struct platform_device *pdev)
419 {
420 const struct dmi_system_id *dmi_entry;
421 struct device *dev = &pdev->dev;
422 struct device *hwdev;
423 int ret;
424
425 /*
426 * Have to check for AMD processor here because DMI strings are the
427 * same between Intel and AMD boards, the only way to tell them apart
428 * is the CPU.
429 * Intel boards seem to have different EC registers and values to
430 * read/write.
431 */
432 dmi_entry = dmi_first_match(dmi_table);
433 if (!dmi_entry || boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
434 return -ENODEV;
435
436 board = (enum oxp_board)(unsigned long)dmi_entry->driver_data;
437
438 switch (board) {
439 case aok_zoe_a1:
440 case oxp_mini_amd_a07:
441 case oxp_mini_amd_pro:
442 ret = devm_device_add_groups(dev, oxp_ec_groups);
443 if (ret)
444 return ret;
> 445 default:
446 }
447
448 hwdev = devm_hwmon_device_register_with_info(dev, "oxpec", NULL,
449 &oxp_ec_chip_info, NULL);
450
451 return PTR_ERR_OR_ZERO(hwdev);
452 }
453

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki