Re: [PATCH v2 21/22] interconnect: qcom: icc-rpm: Set correct bandwidth through RPM bw req

[Stephan Gerhold]

On Fri, Jun 09, 2023 at 10:19:26PM +0200, Konrad Dybcio wrote:
> Currently, we're setting the aggregated-on-provider bandwidth on each
> node, individually. That is of course incorrect and results in far too
> high votes. Use the correct values to ensure we're not wasting power.
> 
> Fixes: 30c8fa3ec61a ("interconnect: qcom: Add MSM8916 interconnect provider driver")
> Reported-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Reviewed-by: Stephan Gerhold <stephan@xxxxxxxxxxx>

> ---
>  drivers/interconnect/qcom/icc-rpm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
> index ac719013077e..1508233632f6 100644
> --- a/drivers/interconnect/qcom/icc-rpm.c
> +++ b/drivers/interconnect/qcom/icc-rpm.c
> @@ -355,12 +355,12 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
>  
>  	qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg);
>  
> -	ret = qcom_icc_rpm_set(src_qn, agg_avg);
> +	ret = qcom_icc_rpm_set(src_qn, src_qn->sum_avg);
>  	if (ret)
>  		return ret;
>  
>  	if (dst_qn) {
> -		ret = qcom_icc_rpm_set(dst_qn, agg_avg);
> +		ret = qcom_icc_rpm_set(dst_qn, dst_qn->sum_avg);
>  		if (ret)
>  			return ret;
>  	}
> 
> -- 
> 2.41.0
>