Re: [PATCH v4 1/3] iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC

From: Jonathan Cameron
Date: Sat Jun 10 2023 - 13:55:41 EST


On Sat, 10 Jun 2023 15:29:07 +0300
Maksim Kiselev <bigunclemax@xxxxxxxxx> wrote:

> From: Maxim Kiselev <bigunclemax@xxxxxxxxx>
>
> The General Purpose ADC (GPADC) can convert the external signal into
> a certain proportion of digital value, to realize the measurement of
> analog signal, which can be applied to power detection and key detection.
>
> Theoretically, this ADC can support up to 16 channels. All SoCs below
> contain this GPADC IP. The only difference between them is the number
> of available channels:
>
> T113 - 1 channel
> D1 - 2 channels
> R329 - 4 channels
> T507 - 4 channels
>
> Signed-off-by: Maxim Kiselev <bigunclemax@xxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Looks good to me. Just the issue Connor pointed out in the DT binding to resolve.
Note that this will be cutting it fine for this cycle, but 'might'
make it in if the stars align. If not it will need to wait for next cycle.

Jonathan