Re: [PATCH v1 3/3] dt-bindings: thermal: sun8i: Add binding for D1/T113s THS controller

[Maxim Kiselev]

сб, 10 июн. 2023 г. в 17:52, Conor Dooley <conor@xxxxxxxxxx>:

...

>
> Signed-off-by: Maxim Kiselev <bigunclemax@xxxxxxxxx>
> Signed-off-by: Maksim Kiselev <bigunclemax@xxxxxxxxx>
>
>> Why do you have 2 sign-offs that are both you w/ different spellings?

Sorry for that. I accidentally signed it twice.

...

> +  - |
> +    thermal-sensor@2009400 {
> +          compatible = "allwinner,sun20i-d1-ths";
> +          reg = <0x02009400 0x400>;
> +          interrupts = <0 90 0>;
> +          clocks = <&ccu 0>;
> +          clock-names = "bus";
> +          resets = <&ccu 2>;
> +          nvmem-cells = <&ths_calibration>;
> +          nvmem-cell-names = "calibration";
> +          #thermal-sensor-cells = <0>;
>
>> Is this calibration required, or optional, for the d1?

Calibration data for the D1 is optional as for the H6.
(But without it, the sensor data will be inaccurate).