Re: [PATCH 1/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() in case of error

[Christophe JAILLET]

Le 10/06/2023 à 12:26, Andi Shyti a écrit :
> > @@ -1459,8 +1459,10 @@ static unsigned int s3c24xx_serial_getclk(struct s3c24xx_uart_port *ourport,
> >   			continue;
> >   
> >   		rate = clk_get_rate(clk);
> > -		if (!rate)
> > +		if (!rate) {
> > +			clk_put(clk);
> >   			continue;
>
> could you also print an error here?

Is:
	dev_err(ourport->port.dev,
		"Failed to get clock rate for %s.\n", clkname);

fine for you?

CJ