Re: [PATCH 1/3] virtio-crypto: fixup potential cpu stall when free unused bufs

From: Greg KH
Date: Sat Jun 10 2023 - 02:51:10 EST


On Sat, Jun 10, 2023 at 11:20:49AM +0800, Xianting Tian wrote:
>
> 在 2023/6/9 下午11:57, Michael S. Tsirkin 写道:
> > On Fri, Jun 09, 2023 at 09:18:15PM +0800, Xianting Tian wrote:
> > > From: Xianting Tian <tianxianting.txt@xxxxxxxxxxxxxxx>
> > >
> > > Cpu stall issue may happen if device is configured with multi queues
> > > and large queue depth, so fix it.
> > What does "may happen" imply exactly?
> > was this observed?
> I didn't met such issue, this patch set just a theoretical fix.

Then I would not recommend adding it at this time, as you just slowed
down the kernel for something that no one has reported :(

thanks,

greg k-h