RE: [PATCH 1/2] ASoC: dt-bindings: max98388: add amplifier driver

[Lee, RyanS]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Thursday, June 8, 2023 12:18 AM
> To: “Ryan <ryan.lee.analog@xxxxxxxxx>; lgirdwood@xxxxxxxxx;
> broonie@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; perex@xxxxxxxx; tiwai@xxxxxxxx;
> rf@xxxxxxxxxxxxxxxxxxxxx; Lee, RyanS <RyanS.Lee@xxxxxxxxxx>;
> wangweidong.a@xxxxxxxxxx; shumingf@xxxxxxxxxxx;
> herve.codina@xxxxxxxxxxx; ckeepax@xxxxxxxxxxxxxxxxxxxxx;
> doug@xxxxxxxxxxxxx; ajye_huang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx;
> kiseok.jo@xxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: venkataprasad.potturu@xxxxxxx
> Subject: Re: [PATCH 1/2] ASoC: dt-bindings: max98388: add amplifier driver
> 
> [External]
> 
> On 08/06/2023 07:42, “Ryan wrote:
> > From: Ryan Lee <ryans.lee@xxxxxxxxxx>
> >
> > Add dt-bindings information for Analog Devices MAX98388 I2S Amplifier
> >
> > Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxx>
> 
> Thank you for your patch. There is something to discuss/improve.
Thanks for the comments. I shall fix the issues and submit the patch again.

> 
> > +
> > +allOf:
> > +  - $ref: dai-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,max98388
> 
> Blank line
> 
> > +  reg:
> > +    maxItems: 1
> > +    description: I2C address of the device.
> 
> Drop description, it's obvious.
> 
> > +
> > +  '#sound-dai-cells':
> > +    const: 0
> > +
> > +  adi,vmon-slot-no:
> > +    description: slot number of the voltage feedback monitor
> > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> 
> Drop quotes.
> 
> > +    minimum: 0
> > +    maximum: 15
> > +    default: 0
> > +
> > +  adi,imon-slot-no:
> > +    description: slot number of the current feedback monitor
> > +    $ref: "/schemas/types.yaml#/definitions/uint32"
> 
> Drop quotes.
> 
> > +    minimum: 0
> > +    maximum: 15
> > +    default: 1
> > +
> > +  adi,interleave-mode:
> > +    description:
> > +      For cases where a single combined channel for the I/V feedback data
> > +      is not sufficient, the device can also be configured to share
> > +      a single data output channel on alternating frames.
> > +      In this configuration, the current and voltage data will be frame
> > +      interleaved on a single output channel.
> > +    type: boolean
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - "#sound-dai-cells"
> 
> Keep consistent quotes - either ' or "
> 
> > +
> > +unevaluatedProperties: false
> 
> 
> Best regards,
> Krzysztof