Re: [PATCH v2 2/2] NFC: nxp-nci: Add pad supply voltage pvdd-supply

From: Raymond Hackley
Date: Fri Jun 09 2023 - 16:52:58 EST


Hi Mark,

On Friday, June 9th, 2023 at 7:34 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:

> Specifically your driver should only ever call regulator_disable() to
> balance out regulator_enable() calls it made itself and it should know
> how many of those it has done. regulator_is_enabled() should only ever
> be used during probe if for some reason it is important to figure out if
> the device is already powered for startup, this should be very unusual.
> If something else enabled the regualtor then whatever did that needs to
> undo those enables, not another driver.

Thnak you for explanation. I should drop regulator_is_enabled() here since
it's misused.

Regards,
Raymond