Re: [PATCH net-next] net: ethtool: Fix out-of-bounds copy to user

[Alexander Duyck]

On Fri, Jun 9, 2023 at 10:13 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Fri, 9 Jun 2023 23:25:34 +0800 Ding Hui wrote:
> > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c: .get_sset_count         = nfp_net_get_sset_count,
> > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c: .get_sset_count         = nfp_port_get_sset_count,
>
> Not sure if your research is accurate, NFP does not change the number
> of stats. The number depends on the device and the FW loaded, but those
> are constant during a lifetime of a netdevice.

Yeah, the value doesn't need to be a constant, it just need to be constant.

So for example in the ixgbe driver I believe we were using the upper
limits on the Tx and Rx queues which last I recall are stored in the
netdev itself.