Re: [PATCH] HID: sensor-hub: Allow multi-function sensor devices

From: Jiri Kosina
Date: Fri Jun 09 2023 - 11:44:54 EST


On Sun, 28 May 2023, Daniel Thompson wrote:

> The Lenovo Yoga C630 has a combined keyboard and accelerometer that
> interfaces via i2c-hid. Currently this laptop either has a working
> keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working accelerometer.
> only works on kernels. Put another way, most distro kernels enable
> CONFIG_HID_SENSOR_HUB and therefore cannot work on this device since the
> keyboard doesn't work!
>
> Fix this by providing a richer connect mask during the probe. With this
> change both keyboard and screen orientation sensors work correctly.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

Srinivas, are you aware of any multi-function device that this patch might
break?

Thanks,

--
Jiri Kosina
SUSE Labs