Re: [PATCH] Revert "ASoC: mediatek: mt8192-mt6359: Remove " Jack" from Headphone pin name"

From: Mark Brown
Date: Fri Jun 09 2023 - 09:13:50 EST


On Fri, Jun 09, 2023 at 09:08:47AM -0400, Nícolas F. R. A. Prado wrote:
> On Fri, Jun 09, 2023 at 10:39:25AM +0100, Mark Brown wrote:

> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
> > There's no need to resubmit to fix this alone.

> just for my own reference in the future, what exactly should have been done
> differently in this commit? Are the subject line and commit reference in the
> message generated by 'git revert' no good? Or is this message from a bot that
> can't handle revert commits?

Yes, what git revert generates by default are no good and you should
edit it to look like a normal commit message with a standard subject
line and standard way of referencing other commits.

Attachment: signature.asc
Description: PGP signature