Re: [PATCH] block: fix rootwait= again

From: Marek Szyprowski
Date: Fri Jun 09 2023 - 06:55:46 EST


On 09.06.2023 07:17, Christoph Hellwig wrote:
> The previous rootwait fix added an -EINVAL return to a completely
> bogus superflous branch, fix this.
>
> Fixes: 1341c7d2ccf4 ("block: fix rootwait=")
> Reported-by: Mark Brown <broonie@xxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Tested-by: Fabio Estevam <festevam@xxxxxxxxx>

This fixes the issue I've found in today's next-20230609.

Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>


> ---
> block/early-lookup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/early-lookup.c b/block/early-lookup.c
> index 48ea3e982419cc..a5be3c68ed079c 100644
> --- a/block/early-lookup.c
> +++ b/block/early-lookup.c
> @@ -181,7 +181,7 @@ static int __init devt_from_devname(const char *name, dev_t *devt)
> *p = '\0';
> *devt = blk_lookup_devt(s, part);
> if (*devt)
> - return -ENODEV;
> + return 0;
>
> /* try disk name without p<part number> */
> if (p < s + 2 || !isdigit(p[-2]) || p[-1] != 'p')

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland