Re: [PATCH V2] gpio: zynq: fix zynqmp_gpio not an immutable chip warning

From: Linus Walleij
Date: Fri Jun 09 2023 - 04:06:50 EST


On Thu, Jun 8, 2023 at 8:43 PM Manikanta Guntupalli
<manikanta.guntupalli@xxxxxxx> wrote:

> Make the struct irq_chip const and flag it as IRQCHIP_IMMUTABLE,
> call gpiochip_disable_irq() in the .irq_mask() callback and
> gpiochip_enable_irq() in the .irq_unmask() callback to fix
> "gpio gpiochip1: (zynqmp_gpio): not an immutable chip" warning.
>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@xxxxxxx>

This v2 looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij