Re: [PATCH v3 3/8] dt-bindings: leds: leds-mt6323: Support WLED output

[AngeloGioacchino Del Regno]

Il 02/06/23 10:32, Krzysztof Kozlowski ha scritto:
> On 01/06/2023 13:08, AngeloGioacchino Del Regno wrote:
> > Some PMICs have a separated WLED string output: add a property
> > `mediatek,is-wled` to indicate which LED string is a WLED.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/leds/leds-mt6323.txt | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6323.txt b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > index 052dccb8f2ce..904b2222a5fe 100644
> > --- a/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > +++ b/Documentation/devicetree/bindings/leds/leds-mt6323.txt
> > @@ -30,6 +30,7 @@ Optional properties for the LED child node:
> >   - label : See Documentation/devicetree/bindings/leds/common.txt
> >   - linux,default-trigger : See Documentation/devicetree/bindings/leds/common.txt
> >   - default-state: See Documentation/devicetree/bindings/leds/common.txt
> > +- mediatek,is-wled: LED string is connected to WLED output
>
> Why would it matter to what the output is connected to?

When this property is present, the MT6323 LEDs are managed through different
hardware registers which are specific to WLEDs: if we have no indication of
whether this is a WLED or a LED, we would program the wrong registers.

P.S.: Sorry for the very late reply

> Best regards,
> Krzysztof