Re: [PATCH v5 28/34] perf pmus: Split pmus list into core and other

[Ravi Bangoria]

Hi Ian,

On 27-May-23 12:52 PM, Ian Rogers wrote:
> Split the pmus list into core and other. This will later allow for
> the core and other pmus to be populated separately.
> 
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> ---
>  tools/perf/util/pmus.c | 52 ++++++++++++++++++++++++++++++------------
>  1 file changed, 38 insertions(+), 14 deletions(-)
> 
> diff --git a/tools/perf/util/pmus.c b/tools/perf/util/pmus.c
> index 58ff7937e9b7..4ef4fecd335f 100644
> --- a/tools/perf/util/pmus.c
> +++ b/tools/perf/util/pmus.c
> @@ -12,13 +12,19 @@
>  #include "pmu.h"
>  #include "print-events.h"
>  
> -static LIST_HEAD(pmus);
> +static LIST_HEAD(core_pmus);
> +static LIST_HEAD(other_pmus);

AMD ibs_fetch// and ibs_op// PMUs are per SMT-thread and are independent of
core hw pmu. I wonder where does IBS fit. Currently it's part of other_pmus.
So, is it safe to assume that other_pmus are not just uncore pmus? In that
case shall we add a comment here?

Thanks,
Ravi