Re: [PATCH v8 1/8] drm/etnaviv: add a dedicated function to register an irq handler

[Sui Jingfeng]

Hi,

On 2023/6/9 01:25, Bjorn Helgaas wrote:
> On Wed, Jun 07, 2023 at 06:55:44PM +0800, Sui Jingfeng wrote:
> > From: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> >
> > Because getting IRQ from a device is platform-dependent, PCI devices have
> > different methods for getting an IRQ. This patch is a preparation patch to
> > extend the driver for the PCI device support.
> >
> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > Cc: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
> > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > Signed-off-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 34 ++++++++++++++++++++-------
> >   1 file changed, 25 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > index de8c9894967c..b9c12d3145a2 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
> > @@ -1817,6 +1817,29 @@ static const struct of_device_id etnaviv_gpu_match[] = {
> >   };
> >   MODULE_DEVICE_TABLE(of, etnaviv_gpu_match);
> >   
> > +static int etnaviv_gpu_register_irq(struct etnaviv_gpu *gpu, int irq)
> > +{
> > +	struct device *dev = gpu->dev;
> > +	int err;
> > +
> > +	if (irq < 0) {
> > +		dev_err(dev, "failed to get irq: %d\n", irq);
> Isn't this message redundant because platform_get_irq() already
> emitted a message for this case?
Indeed, will be fixed at version.
> > +		return irq;
> > +	}
> > +
> > +	err = devm_request_irq(dev, irq, irq_handler, 0, dev_name(dev), gpu);
> > +	if (err) {
> > +		dev_err(dev, "failed to request irq %u: %d\n", irq, err);
> > +		return err;
> > +	}
> > +
> > +	gpu->irq = irq;
> > +
> > +	dev_info(dev, "irq(%d) handler registered\n", irq);
> > +
> > +	return 0;
> > +}
> > +
> >   static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
> >   {
> >   	struct device *dev = &pdev->dev;
> > @@ -1837,16 +1860,9 @@ static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
> >   		return PTR_ERR(gpu->mmio);
> >   
> >   	/* Get Interrupt: */
> > -	gpu->irq = platform_get_irq(pdev, 0);
> > -	if (gpu->irq < 0)
> > -		return gpu->irq;
> > -
> > -	err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
> > -			       dev_name(gpu->dev), gpu);
> > -	if (err) {
> > -		dev_err(dev, "failed to request IRQ%u: %d\n", gpu->irq, err);
> > +	err = etnaviv_gpu_register_irq(gpu, platform_get_irq(pdev, 0));
> > +	if (err)
> >   		return err;
> > -	}
> >   
> >   	/* Get Clocks: */
> >   	gpu->clk_reg = devm_clk_get_optional(&pdev->dev, "reg");
> > --
> > 2.25.1
--
Jingfeng