Re: [PATCH RESEND v4 0/2] Fix Goodix touchscreen power leakage for MT8186 boards

From: Jiri Kosina
Date: Thu Jun 08 2023 - 10:20:33 EST


On Wed, 24 May 2023, Fei Shao wrote:

> These changes are based on the series in [1], which modified the
> i2c-hid-of-goodix driver and removed the workaround for a power leakage
> issue, so the issue revisits on Mediatek MT8186 boards (Steelix).
>
> The root cause is that the touchscreen can be powered in different ways
> depending on the hardware designs, and it's not as easy to come up with
> a solution that is both simple and elegant for all the known designs.
>
> To address the issue, I ended up adding a new boolean property for the
> driver so that we can control the power up/down sequence depending on
> that.
>
> Adding a new property might not be the cleanest approach for this, but
> at least the intention would be easy enough to understand, and it
> introduces relatively small change to the code and fully preserves the
> original control flow.

Please apologize the delay. Now applied.

--
Jiri Kosina
SUSE Labs