Re: [PATCH V2 12/13] arm64: dts: qcom: ipq5018: Add RDP432-c1 board support

[Manikanta Mylavarapu]

On 5/30/2023 4:36 PM, Krzysztof Kozlowski wrote:
> On 22/05/2023 00:28, Manikanta Mylavarapu wrote:
> > Add initial device tree support for the RDP432-C1 board.
> >
> > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
> > ---
> > Changes in V2:
> > 	- Renamed mp03.5-c1 to RDP432-c1
> > 	- Removed boot-args
> > 	- Resolved dt-binding error's
> >
> >   arch/arm64/boot/dts/qcom/Makefile             |  1 +
> >   .../arm64/boot/dts/qcom/ipq5018-rdp432-c1.dts | 49 +++++++++++++++++++
> >   2 files changed, 50 insertions(+)
> >   create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp432-c1.dts
> >
> > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> > index 259bd57c6064..bb9164de75b0 100644
> > --- a/arch/arm64/boot/dts/qcom/Makefile
> > +++ b/arch/arm64/boot/dts/qcom/Makefile
> > @@ -3,6 +3,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8016-sbc.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
> > +dtb-$(CONFIG_ARCH_QCOM)	+= ipq5018-rdp432-c1.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5018-rdp432-c2.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-mi01.2.dtb
> >   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp468.dtb
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c1.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c1.dts
> > new file mode 100644
> > index 000000000000..7fe28d9859b0
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp432-c1.dts
> > @@ -0,0 +1,49 @@
> > +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
> > +/*
> > + * IPQ5018 RDP432-C1 board device tree source
> > + *
> > + * Copyright (c) 2023, The Linux Foundation. All rights reserved.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "ipq5018.dtsi"
> > +
> > +/ {
> > +	model = "Qualcomm Technologies, Inc. IPQ5018/AP-RDP432.1-C1";
> > +	compatible = "qcom,ipq5018-rdp432-c1", "qcom,ipq5018";
> > +
> > +	aliases {
> > +		serial0 = &blsp1_uart1;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> > +};
> > +
> > +&blsp1_uart1 {
> > +	pinctrl-0 = <&uart1_pins>;
> > +	pinctrl-names = "default";
> > +	status = "okay";
> > +};
> > +
> > +&q6v5_wcss {
> > +	pd-2 {
> > +		firmware-name = "IPQ5018/q6_fw.mdt";
>
> Does not look like correct paths. Please open firmware and look there.
> Or open other DTS files and check example. Missing qcom, lowercase,
> that's minimum of fixes needed.
>
> Best regards,
> Krzysztof

IPQ5018 firmware files are available here
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ath11k/IPQ5018/hw1.0
I will use 'ath11k/IPQ5018/hw1.0' path.

Thanks & Regards,
Manikanta.