Re: [PATCH net v2] net: pch_gbe: Allow build on MIPS_GENERIC kernel

From: Simon Horman
Date: Thu Jun 08 2023 - 08:08:40 EST


On Wed, Jun 07, 2023 at 01:59:53PM +0800, Jiaxun Yang wrote:
> MIPS Boston board, which is using MIPS_GENERIC kernel is using
> EG20T PCH and thus need this driver.
>
> Dependency of PCH_GBE, PTP_1588_CLOCK_PCH is also fixed for
> MIPS_GENERIC.
>
> Note that CONFIG_PCH_GBE is selected in arch/mips/configs/generic/
> board-boston.config for a while, some how it's never wired up
> in Kconfig.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>
> ---
> v2: Add PTP_1588_CLOCK_PCH dependency.
>
> Netdev maintainers, is it possible to squeeze this tiny patch into
> fixes tree?

That question aside, this looks good to me.

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>