Re: [PATCH v12 1/2] spi: add loongson spi bindings

From: Krzysztof Kozlowski
Date: Thu Jun 08 2023 - 07:46:07 EST


On 08/06/2023 13:42, zhuyinbo wrote:
>>
>>> It can work was for ls2k1000 and ls2k0500 and it specifically refers to
>>> spi driver. but 2k0500 doesn't implementing a clock driver and doesn't
>>
>> We do not discuss here drivers, but bindings. Whatever your drivers are
>> not supporting, matters less.
>>
>>> use CCF to gain clock but can use "clock-frequency". Is it necessary to
>>> obtain a clock based on CCF? If it's necessary, then it seems that it
>>> can only added 2k1000 spi first.
>>
>> Not related to bindings...
>
>
> I may understand that what you said, and the dt-bindings only cover
> hardware and not involve the drivers. if so, I will add following:
>
>
> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml
> @@ -16,6 +16,7 @@ properties:
> compatible:
> enum:
> - loongson,ls2k1000-spi
> + - loongson,ls2k0500-spi

Aren't they compatible?

Best regards,
Krzysztof