Re: [PATCH v12 2/2] spi: loongson: add bus driver for the loongson spi controller

From: Andy Shevchenko
Date: Thu Jun 08 2023 - 06:19:05 EST


On Thu, Jun 8, 2023 at 1:15 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Thu, Jun 8, 2023 at 10:28 AM Yinbo Zhu <zhuyinbo@xxxxxxxxxxx> wrote:




> > + ret = readb_poll_timeout(loongson_spi->base + LOONGSON_SPI_SPSR_REG, loongson_spi->spsr,
> > + (loongson_spi->spsr & 0x1) != LOONGSON_SPI_SPSR_RFEMPTY, 1, MSEC_PER_SEC);
>
> (loongson_spi->spsr &
> LOONGSON_SPI_SPSR_RFEMPTY) != LOONGSON_SPI_SPSR_RFEMPTY,
> 1, MSEC_PER_SEC);

Actually the last should be USEC_PER_MSEC, as the parameter is in microseconds.

--
With Best Regards,
Andy Shevchenko