Re: [PATCH 2/5] ASoC: mediatek: mt8188-mt6359: clean up a return in codec_init

From: Alexandre Mergnat
Date: Thu Jun 08 2023 - 05:33:32 EST


On 08/06/2023 10:47, AngeloGioacchino Del Regno wrote:
This code triggers a Smatch static checker warning and does sort of
look like an error path.

sound/soc/mediatek/mt8188/mt8188-mt6359.c:597 mt8188_max98390_codec_init() warn: missing error code? 'ret'

However, returning 0 is intentional. Make that explicit.

Reviewed-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>

--
Regards,
Alexandre