Re: [v6 1/4] dt-bindings: pwm: Add ASPEED PWM Control documentation

From: Krzysztof Kozlowski
Date: Thu Jun 08 2023 - 04:36:48 EST


On 08/06/2023 10:21, Billy Tsai wrote:
> On 08/06/2023 09:47, Billy Tsai wrote:
> >>
> >> >> +
> >> >> +allOf:
> >> >> + - $ref: pwm.yaml#
> >> >> +
> >> >> +properties:
> >> >> + compatible:
> >> >> + enum:
> >> >> + - aspeed,ast2600-pwm
> >> >> +
> >> >> + "#pwm-cells":
> >> >> + const: 3
> >>
> >> > 3 cells? For one PWM? What are they?
> >>
> >> channel, period and polarity.
>
> > Don't cut my responses. You wrote you have one PWM output, so only one
> > channel. What do you put then in the channel?
>
> You need to put 0 in the cell of the channel, the example of the dts usage will like following:

If you always put 0 isn't this a proof that it's wrong?



Best regards,
Krzysztof