Re: [PATCH v2] fs: avoid empty option when generating legacy mount string

From: Christian Brauner
Date: Thu Jun 08 2023 - 03:34:27 EST


On Wed, Jun 07, 2023 at 07:39:09PM +0200, Thomas Weißschuh wrote:
> As each option string fragment is always prepended with a comma it would
> happen that the whole string always starts with a comma.
> This could be interpreted by filesystem drivers as an empty option and
> may produce errors.
>
> For example the NTFS driver from ntfs.ko behaves like this and fails when
> mounted via the new API.
>
> Link: https://github.com/util-linux/util-linux/issues/2298
> Fixes: 3e1aeb00e6d1 ("vfs: Implement a filesystem superblock creation/configuration context")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> ---

Applied a fixed up version of v1 to

tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc

[1/1] fs: avoid empty option when generating legacy mount string
https://git.kernel.org/vfs/vfs/c/36851649d3f6

yesterday.