Re: [PATCH 1/2] x86/microcode/AMD: Load late on both threads too

From: Dave Hansen
Date: Wed Jun 07 2023 - 16:16:02 EST


On 6/7/23 13:03, Borislav Petkov wrote:
> On Wed, Jun 07, 2023 at 12:36:53PM -0700, Dave Hansen wrote:
>> What's the benefit of doing the loading on both threads? I would have
>> naively thought it was just wasted work.
> I have the perfect example for this, see:
>
> e7ad18d1169c ("x86/microcode/AMD: Apply the patch early on every logical thread")
>
> so it is for reasons like that.

Yikes, so the second CMT thread reports a bumped version but not all the
_effects_ of that version? That's, uh ... fun???

>> I think I even have a back-burnered Intel patch around somewhere that
>> ensures that we *never* load on both threads.
> Interesting - I guess there are considerable differences in microcode
> architecture between the two. 😄

Yeah, sure seems that way.