Re: [PATCH 2/3] thermal: qoriq_thermal: only enable supported sensors

From: Daniel Lezcano
Date: Wed Jun 07 2023 - 15:10:26 EST


On 07/06/2023 19:42, Sebastian Krzyszkowiak wrote:

[ ... ]

Hence, the thermal_zone_device_register_with_trips() is not called, the
thermal zone is not created neither updated.

Again - that's not the case the check is there for. It's there for zones that
do exist and that do get registered, because REGS_TMR only gets set *after*
all the zones are already registered (the driver as it is right now does not
know which sites it should enable before registering the zones). Because of
that, the first value a zone gets after being registered is always bogus,
because no monitoring site has been enabled yet at all.

Ok, I misunderstood. I thought that was for failing registered thermal zone.

Would enabling the site in ops->change_mode do the trick ?







--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog