Re: [PATCH v2 0/2] Add MHI Endpoint network driver

From: Andrew Lunn
Date: Wed Jun 07 2023 - 14:15:52 EST


On Wed, Jun 07, 2023 at 09:49:22AM -0700, Jakub Kicinski wrote:
> On Wed, 7 Jun 2023 20:54:25 +0530 Manivannan Sadhasivam wrote:
> > This series adds a network driver for the Modem Host Interface (MHI) endpoint
> > devices that provides network interfaces to the PCIe based Qualcomm endpoint
> > devices supporting MHI bus (like Modems). This driver allows the MHI endpoint
> > devices to establish IP communication with the host machines (x86, ARM64) over
> > MHI bus.
> >
> > On the host side, the existing mhi_net driver provides the network connectivity
> > to the host.
>
> Why are you posting the next version before the discussion on the
> previous one concluded? :|
>
> In any case, I'm opposed to reuse of the networking stack to talk
> to firmware. It's a local device. The networking subsystem doesn't
> have to cater to fake networks. Please carry:
>
> Nacked-by: Jakub Kicinski <kuba@xxxxxxxxxx>

Remote Processor Messaging (rpmsg) Framework does seem to be what is
supposed to be used for these sorts of situations. Not that i know
much about it.

Andrew