Re: [PATCH net-next v2] net: liquidio: fix mixed module-builtin object

From: Simon Horman
Date: Wed Jun 07 2023 - 04:08:53 EST


On Wed, Jun 07, 2023 at 02:18:49AM +0900, Masahiro Yamada wrote:
> With CONFIG_LIQUIDIO=m and CONFIG_LIQUIDIO_VF=y (or vice versa),
> $(common-objs) are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
>
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
>
> Introduce the new module, liquidio-core, to provide the common functions
> to liquidio and liquidio-vf.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
> ---
>
> Changes in v2:
> - Export lio_get_state_string
> - Remove $(common-objs) from Makefile

Thanks. FWIIW, I did verify that an x86_64 allmodconfig build
runs successfully. Apologies to all for missing that in v1.