Re: [Intel-gfx] [PATCH v2 1/2] vgaarb: various coding style and comments fix

[Sui Jingfeng]

Hi,

On 2023/6/7 03:49, Bjorn Helgaas wrote:
> Match the subject line style:
>
>    $ git log --oneline drivers/pci/vgaarb.c
>    f321c35feaee PCI/VGA: Replace full MIT license text with SPDX identifier
>    d5109fe4d1ec PCI/VGA: Use unsigned format string to print lock counts
>    4e6c91847a7f PCI/VGA: Log bridge control messages when adding devices
>    dc593fd48abb PCI/VGA: Remove empty vga_arb_device_card_gone()
>    ...
>
> Subject line should be a summary of the commit log, not just "various
> style fixes".  This one needs to say something about
> vga_str_to_iostate().

Ok, thanks for the educating .

> On Mon, Jun 05, 2023 at 04:58:30AM +0800, Sui Jingfeng wrote:
> > From: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> >
> > To keep consistent with vga_iostate_to_str() function, the third argument
> > of vga_str_to_iostate() function should be 'unsigned int *'.
> >
> > Signed-off-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
> > ---
> >   drivers/pci/vgaarb.c   | 29 +++++++++++++++--------------
> >   include/linux/vgaarb.h |  8 +++-----
> >   2 files changed, 18 insertions(+), 19 deletions(-)
> >
> > diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c
> > index 5a696078b382..e40e6e5e5f03 100644
> > --- a/drivers/pci/vgaarb.c
> > +++ b/drivers/pci/vgaarb.c
> > @@ -61,7 +61,6 @@ static bool vga_arbiter_used;
> >   static DEFINE_SPINLOCK(vga_lock);
> >   static DECLARE_WAIT_QUEUE_HEAD(vga_wait_queue);
> >   
> > -
> >   static const char *vga_iostate_to_str(unsigned int iostate)
> >   {
> >   	/* Ignore VGA_RSRC_IO and VGA_RSRC_MEM */
> > @@ -77,10 +76,12 @@ static const char *vga_iostate_to_str(unsigned int iostate)
> >   	return "none";
> >   }
> >   
> > -static int vga_str_to_iostate(char *buf, int str_size, int *io_state)
> > +static int vga_str_to_iostate(char *buf, int str_size, unsigned int *io_state)
> >   {
> > -	/* we could in theory hand out locks on IO and mem
> > -	 * separately to userspace but it can cause deadlocks */
> > +	/*
> > +	 * we could in theory hand out locks on IO and mem
> > +	 * separately to userspace but it can cause deadlocks
> > +	 */
> Omit all the comment formatting changes.  They are distractions from the
> vga_str_to_iostate() parameter change.
>
> I think this patch should be the single line change to the
> vga_str_to_iostate() prototype so it matches the callers.
>
> If you want to do the other comment formatting changes, they're fine,
> but they should be all together in a separate patch that clearly
> doesn't change the generated code.

Ok, no problem.

Will be improved at next version.

> Bjorn