RE: [PATCH v3 2/5] gpio: gxp: Add HPE GXP GPIO

From: Hawkins, Nick
Date: Tue Jun 06 2023 - 14:52:34 EST


Hi Andy,

Thanks for the feedback. I have a question below:

> > + base = devm_platform_ioremap_resource_byname(pdev, reg_name);
> > + if (IS_ERR(base))
> > + return ERR_CAST(base);
> > +
> > + regmap_config.name = reg_name;
> > +
> > + return devm_regmap_init_mmio(&pdev->dev, base, &regmap_config);

> Why are you not using gpio-regmap?

Is there are good example or previous commit you would recommend
looking at that shows how to convert from regmap to gpio-regmap?
Later in the code I am using regmap_read and regmap_update_bits
with large differences in offset registers, and not so much a
contiguous block.

Thank you for the review and assistance!

-Nick Hawkins