Re: [PATCH net-next v2 0/3] Followup fixes for the dwmac and altera lynx conversion

From: Maxime Chevallier
Date: Tue Jun 06 2023 - 10:53:43 EST


Hello Russell,

On Tue, 6 Jun 2023 15:32:53 +0100
"Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx> wrote:

> On Tue, Jun 06, 2023 at 04:21:41PM +0200, Maxime Chevallier wrote:
> > Following the TSE PCS removal and port of altera_tse and dwmac_socfpga,
> > this series fixes some issues that slipped through the cracks.
> >
> > Patch 1 fixes an unitialized struct in altera_tse
> >
> > Patch 2 uses the correct Kconfig option for altera_tse
> >
> > Patch 3 makes the Lynx PCS specific to dwmac_socfpga. This patch was
> > originally written by Russell, my modifications just moves the
> > #include<linux/pcs-lynx.h> around, to use it only in dwmac_socfpga.
>
> Hi Maxime,
>
> I'm sorry, but I think you need an extra patch added to this series.

Gosh you're right... The same this also goes for altera_tse...

> Other than that, the series looks good. Thanks.

I'll followup shortly then. Nice catch !

Thanks,

Maxime