Re: [PATCH v4 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC

[Andy Shevchenko]

On Tue, Jun 6, 2023 at 3:45 PM jerome Neanne <jneanne@xxxxxxxxxxxx> wrote:
> On 30/05/2023 13:07, andy.shevchenko@xxxxxxxxx wrote:
> > Tue, May 30, 2023 at 09:59:59AM +0200, Jerome Neanne kirjoitti:

...

> >> Datasheet describes specific usage for non standard GPIO.
> >> Link: https://www.ti.com/lit/ds/symlink/tps65219.pdf
> >
> > Can you convert this to be a Datasheet tag? Currently even Link is *not* a tag
> > because there must be no blank lines in the tag block.
> >
> >> Co-developed-by: Jonathan Cormier <jcormier@xxxxxxxxxxxxxxxx>
> >> Signed-off-by: Jonathan Cormier <jcormier@xxxxxxxxxxxxxxxx>
> >> Signed-off-by: Jerome Neanne <jneanne@xxxxxxxxxxxx>
> >
> I misinterpreted this comment. I looked at wrong examples but I think I
> understand now that the right usage is to have all the tags grouped
> together into one block which is delimited by blank lines before and
> after the whole block.

(Note, there is no "after", tag block is the last in the commit message)

> I'll then do this and put all the Datasheet/Link into the tag block.
> Stop putting Links inside the commit message right after I refer to it.
> https://www.kernel.org/doc/html/latest/process/5.Posting.html#patch-formatting-and-changelogs

-- 
With Best Regards,
Andy Shevchenko