Re: [PATCH v4 1/2] hwmon: (nct6775) Directly call ASUS ACPI WMI method

[Guenter Roeck]

On 6/6/23 03:29, Geert Uytterhoeven wrote:
> Hi Denis,
>
> On Wed, Jan 11, 2023 at 10:24 PM Denis Pauk <pauk.denis@xxxxxxxxx> wrote:
> > New ASUS B650/B660/X670 boards firmware have not exposed WMI monitoring
> > GUID  and entrypoint method WMBD could be implemented for different device
> > UID.
> >
> > Implement the direct call to entrypoint method for monitoring the device
> > UID of B550/X570 boards.
> >
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=204807
> > Signed-off-by: Denis Pauk <pauk.denis@xxxxxxxxx>
> > Co-developed-by: Ahmad Khalifa <ahmad@xxxxxxxxxx>
> > Signed-off-by: Ahmad Khalifa <ahmad@xxxxxxxxxx>
>
> Thanks for your patch, which is now commit c3b3747d02f571da ("hwmon:
> (nct6775) Directly call ASUS ACPI WMI method") in  v6.3-rc1.
>
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -1516,7 +1516,7 @@ config SENSORS_NCT6775_CORE
> >   config SENSORS_NCT6775
> >          tristate "Platform driver for Nuvoton NCT6775F and compatibles"
> >          depends on !PPC
> > -       depends on ACPI_WMI || ACPI_WMI=n
> > +       depends on ACPI || ACPI=n
> >          select HWMON_VID
> >          select SENSORS_NCT6775_CORE
> >          help
>
> The recent patches to add support for ACPI on RISC-V caused me to
> see a question about this driver again when running "make oldconfig",
> and I had a closer look at the driver...
> Unless I am missing something, this is a really dangerous driver which
> just bangs blindly into I/O space without doing any platform checks,
> which could cause a crash or system lock-up?
>
> Does the SENSORS_NCT6775 symbol need a better platform dependenc
> than !PPC?

This is no different than all the other SuperIO drivers.

Guenter