Re: [PATCH 1/2] regulator: act8945a: rely on hardware for operating mode

From: Mark Brown
Date: Tue Jun 06 2023 - 08:56:26 EST


On Tue, Jun 06, 2023 at 12:30:07PM +0530, Raag Jadav wrote:
> On Mon, Jun 05, 2023 at 05:30:36PM +0100, Mark Brown wrote:

> > If we have those then we've got a bigger problem, for example we might
> > switch to a lower power mode which can't support the load we're trying
> > to get the consumer to run.

> Yes, but in such cases it will atleast report whatever mode currently
> set in the hardware and not the incorrect one stored locally in the memory,
> and this way I think we have a better chance of finding out that
> there indeed is a problem.

If this is a concern you should add something that verifies that the
mode hasn't changed underneath the driver, this won't actually detect
any corruption - it just might silently fix it.

Attachment: signature.asc
Description: PGP signature