Re: [PATCH] net: liquidio: fix mixed module-builtin object

[Paolo Abeni]

Hi,

On Sun, 2023-06-04 at 13:32 +0900, Masahiro Yamada wrote:
> With CONFIG_LIQUIDIO=m and CONFIG_LIQUIDIO_VF=y (or vice versa),
> $(common-objs) are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules.
> 
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
> 
> Introduce the new module, liquidio-core, to provide the common functions
> to liquidio and liquidio-vf.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>

This does not build with allmodconfig:

ERROR: modpost: "lio_get_state_string" [drivers/net/ethernet/cavium/liquidio/liquidio.ko] undefined!
ERROR: modpost: "lio_get_state_string" [drivers/net/ethernet/cavium/liquidio/liquidio_vf.ko] undefined!

Please, when you repost include the 'net-next' tag into the subj.

Thanks!

Paolo