Re: [PATCH net] pds_core: Fix FW recovery detection

[Simon Horman]

On Mon, Jun 05, 2023 at 12:51:16PM -0700, Brett Creeley wrote:
> Commit 523847df1b37 ("pds_core: add devcmd device interfaces") included
> initial support for FW recovery detection. Unfortunately, the ordering
> in pdsc_is_fw_good() was incorrect, which was causing FW recovery to be
> undetected by the driver. Fix this by making sure to update the cached
> fw_status by calling pdsc_is_fw_running() before setting the local FW
> gen.
> 
> Fixes: 523847df1b37 ("pds_core: add devcmd device interfaces")
> Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxx>
> Signed-off-by: Brett Creeley <brett.creeley@xxxxxxx>

Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>