Re: [PATCH] mt76: mt7615: do not advertise 5 GHz on first phy of MT7615D (DBDC)

[Simon Horman]

On Mon, Jun 05, 2023 at 10:34:07AM +0300, Paul Fertser wrote:
> On DBDC devices the first (internal) phy is only capable of using
> 2.4 GHz band, and the 5 GHz band is exposed via a separate phy object,
> so avoid the false advertising.

Hi Paul,

Can I clarify that the second object won't hit the logic change
below and thus be limited to 2GHz?

> Reported-by: Rani Hod <rani.hod@xxxxxxxxx>
> Closes: https://github.com/openwrt/openwrt/pull/12361
> Fixes: 7660a1bd0c22 ("mt76: mt7615: register ext_phy if DBDC is detected")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Fertser <fercerpav@xxxxxxxxx>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> index 68e88224b8b1..ccedea7e8a50 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/eeprom.c
> @@ -128,12 +128,12 @@ mt7615_eeprom_parse_hw_band_cap(struct mt7615_dev *dev)
>  	case MT_EE_5GHZ:
>  		dev->mphy.cap.has_5ghz = true;
>  		break;
> -	case MT_EE_2GHZ:
> -		dev->mphy.cap.has_2ghz = true;
> -		break;
>  	case MT_EE_DBDC:
>  		dev->dbdc_support = true;
>  		fallthrough;
> +	case MT_EE_2GHZ:
> +		dev->mphy.cap.has_2ghz = true;
> +		break;
>  	default:
>  		dev->mphy.cap.has_2ghz = true;
>  		dev->mphy.cap.has_5ghz = true;
> -- 
> 2.34.1
> 
>