Re: [PATCH net-next v2 10/10] crypto: af_alg/hash: Support MSG_SPLICE_PAGES

From: Herbert Xu
Date: Tue Jun 06 2023 - 04:44:32 EST


On Tue, May 30, 2023 at 03:16:34PM +0100, David Howells wrote:
>
> - if (limit > sk->sk_sndbuf)
> - limit = sk->sk_sndbuf;
> + /* Don't limit to ALG_MAX_PAGES if the pages are all already pinned. */
> + if (!user_backed_iter(&msg->msg_iter))
> + max_pages = INT_MAX;
> + else
> + max_pages = min_t(size_t, max_pages,
> + DIV_ROUND_UP(sk->sk_sndbuf, PAGE_SIZE));

What's the purpose of relaxing this limit? Even if there is a reason
for this shouldn't this be in a patch by itself?

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt