Re: [PATCH] crypto: Fix checkpatch issues

From: Herbert Xu
Date: Tue Jun 06 2023 - 04:22:11 EST


On Sat, Jun 03, 2023 at 04:24:53PM +0200, Franziska Naepelt wrote:
> crypto/crct10dif_common.c
> - WARNING: Missing or malformed SPDX-License-Identifier tag
>
> crypto/fcrypt.c
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> - WARNING: Block comments use a trailing */ on a separate line
>
> crypto/hmac.c
> - WARNING: Missing a blank line after declarations
>
> crypto/md4.c
> - WARNING: Missing or malformed SPDX-License-Identifier tag
> - ERROR: space required after that ',' (ctx:VxV)
> - ERROR: space prohibited after that open square bracket '['
> - WARNING: space prohibited between function name and open parenthesis '('
> - ERROR: code indent should use tabs where possible
>
> not fixed:
> crypto/md4.c
> - ERROR: space required after that ',' (ctx:VxV)
> Lines 64, 65, 66 have not been fixed due to readability
>
> Signed-off-by: Franziska Naepelt <franziska.naepelt@xxxxxxxxx>
> ---
> crypto/crct10dif_common.c | 1 +
> crypto/fcrypt.c | 4 +++-
> crypto/hmac.c | 1 +
> crypto/md4.c | 11 ++++++-----
> 4 files changed, 11 insertions(+), 6 deletions(-)

Please split these up into individual patches.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt