Re: [PATCHv3 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors
From: kernel test robot
Date: Tue Jun 06 2023 - 03:22:13 EST
Hi Grant,
kernel test robot noticed the following build errors:
[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus linus/master v6.4-rc5 next-20230606]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Grant-Grundler/PCI-AER-Rate-limit-the-reporting-of-the-correctable-errors/20230606-115515
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20230606035442.2886343-2-grundler%40chromium.org
patch subject: [PATCHv3 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20230606/202306061553.YXoBaXAM-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build):
git remote add pci https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git
git fetch pci next
git checkout pci/next
b4 shazam https://lore.kernel.org/r/20230606035442.2886343-2-grundler@xxxxxxxxxxxx
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/pci/pcie/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306061553.YXoBaXAM-lkp@xxxxxxxxx/
All error/warnings (new ones prefixed by >>):
drivers/pci/pcie/aer.c: In function '__aer_print_error':
>> drivers/pci/pcie/aer.c:717:44: error: expected ';' before ':' token
717 | pci_err(dev, "%s", aer_msg):
| ^
In file included from include/linux/device.h:15,
from include/linux/pci.h:37,
from drivers/pci/pcie/aer.c:20:
drivers/pci/pcie/aer.c: In function 'aer_print_error':
>> drivers/pci/pcie/aer.c:15:21: warning: too many arguments for format [-Wformat-extra-args]
15 | #define pr_fmt(fmt) "AER: " fmt
| ^~~~~~~
include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
110 | _p_func(dev, fmt, ##__VA_ARGS__); \
| ^~~
drivers/pci/pcie/aer.c:16:17: note: in expansion of macro 'pr_fmt'
16 | #define dev_fmt pr_fmt
| ^~~~~~
include/linux/dev_printk.h:144:56: note: in expansion of macro 'dev_fmt'
144 | dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~
include/linux/pci.h:2600:41: note: in expansion of macro 'dev_err'
2600 | #define pci_err(pdev, fmt, arg...) dev_err(&(pdev)->dev, fmt, ##arg)
| ^~~~~~~
drivers/pci/pcie/aer.c:743:17: note: in expansion of macro 'pci_err'
743 | pci_err(dev, "PCIe Bus Error: severity=%s, type=%s, (%s)\n",
| ^~~~~~~
drivers/pci/pcie/aer.c: At top level:
drivers/pci/pcie/aer.c:626:13: warning: 'pci_dev_aer_stats_incr' defined but not used [-Wunused-function]
626 | static void pci_dev_aer_stats_incr(struct pci_dev *pdev,
| ^~~~~~~~~~~~~~~~~~~~~~
vim +717 drivers/pci/pcie/aer.c
684
685 static void __aer_print_error(struct pci_dev *dev,
686 struct aer_err_info *info)
687 {
688 const char **strings;
689 char aer_msg[512];
690 unsigned long status = info->status & ~info->mask;
691 int i;
692
693 memset(aer_msg, 0, sizeof(*aer_msg));
694 snprintf(aer_msg, sizeof(*aer_msg), "aer_status: 0x%08x, aer_mask: 0x%08x\n",
695 info->status, info->mask);
696
697 strings = (info->severity == AER_CORRECTABLE) ?
698 aer_correctable_error_string : aer_uncorrectable_error_string;
699
700 for_each_set_bit(i, &status, 32) {
701 const char *errmsg = strings[i];
702 char bitmsg[64];
703 memset(bitmsg, 0, sizeof(*bitmsg));
704
705 if (!errmsg)
706 errmsg = "Unknown Error Bit";
707
708 snprintf(bitmsg, sizeof(*bitmsg), " [%2d] %-22s%s\n", i, errmsg,
709 info->first_error == i ? " (First)" : "");
710
711 strlcat(aer_msg, bitmsg, sizeof(*aer_msg));
712 }
713
714 if (info->severity == AER_CORRECTABLE)
715 pci_info_ratelimited(dev, "%s", aer_msg);
716 else
> 717 pci_err(dev, "%s", aer_msg):
718
719 pci_dev_aer_stats_incr(dev, info);
720 }
721
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki