Re: [PATCH V3 0/1] perf tools: Allow config terms with breakpoints

[Adrian Hunter]

On 25/05/23 11:29, Adrian Hunter wrote:
> Hi
> 
> Here is a patch (V3) to the event parser for breakpoint events.
> I am not that familiar with flex / bison, but it seemed to
> need trailing context to stop the mem event colon and slash
> delimiters from getting mixed up with delimiters for config
> terms or event modifiers.  Please look closely at that.
> 
> 
> Changes in V3:
> 
>       Add Ian's Reviewed-by
>       Re-base

Still applies.  Any more comments?

> 
> Changes in V2:
> 
>       Add comments to tools/perf/util/parse-events.l
>       Add a test for 2 mem events back to back with config terms
> 
> 
> Adrian Hunter (1):
>       perf tools: Allow config terms with breakpoints
> 
>  tools/perf/tests/parse-events.c | 157 ++++++++++++++++++++++++++++++++++++++++
>  tools/perf/util/parse-events.c  |  23 +++++-
>  tools/perf/util/parse-events.h  |   6 +-
>  tools/perf/util/parse-events.l  |  23 +++++-
>  tools/perf/util/parse-events.y  |  42 ++++++-----
>  5 files changed, 224 insertions(+), 27 deletions(-)
> 
> 
> Regards
> Adrian