RE: [PATCH v2 1/2] dt-bindings:iio:adc: add max14001

[Paller, Kim Seer]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Monday, June 5, 2023 9:30 PM
> To: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>; jic23@xxxxxxxxxx;
> lars@xxxxxxxxxx
> Cc: broonie@xxxxxxxxxx; lgirdwood@xxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 1/2] dt-bindings:iio:adc: add max14001
> 
> [External]
> 
> On 05/06/2023 15:07, Kim Seer Paller wrote:
> > The MAX14001 is configurable, isolated 10-bit ADCs for multi-range
> > binary inputs.
> >
> > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people and
> lists to CC.  It might happen, that command when run on an older kernel,
> gives you outdated entries.  Therefore please be sure you base your patches
> on recent Linux kernel.
> 
> You missed at least DT list (maybe more), so this won't be tested.
> Please resend and include all necessary entries.
> 
> Subject - ignored comments.
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all requested
> changes or keep discussing them.

Thank you for your input. I appreciate your feedback, and I apologize for not 
addressing all your previous comments. It seems I may have missed them.

> 
> Thank you.
> 
> > ---
> >  .../bindings/iio/adc/adi,max14001.yaml        | 55 +++++++++++++++++++
> >  MAINTAINERS                                   |  7 +++
> >  2 files changed, 62 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml
> > b/Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml
> > new file mode 100644
> > index 000000000..1b17f5dc0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) # Copyright 2023
> > +Analog Devices Inc.
> > +%YAML 1.2
> > +---
> > +$id:
> > +https://urldefense.com/v3/__http://devicetree.org/schemas/iio/adc/adi
> >
> +,max14001.yaml*__;Iw!!A3Ni8CS0y2Y!4kyf116cWnmdDQYfS_6HwdLqnsCd3
> mGIDAG
> > +uHyornecB2wjo6Yv3S6YD88DRCVplVQhyOVYNvhfSdA-
> gyquDGZpeBZP25Wg$
> > +$schema:
> > +https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/core.y
> >
> +aml*__;Iw!!A3Ni8CS0y2Y!4kyf116cWnmdDQYfS_6HwdLqnsCd3mGIDAGuH
> yornecB2w
> > +jo6Yv3S6YD88DRCVplVQhyOVYNvhfSdA-gyquDGZpe_rIl2_c$
> > +
> > +title: Analog Devices MAX14001 ADC
> > +
> > +maintainers:
> > +  - Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > +
> > +description: |
> > +    Single channel 10 bit ADC with SPI interface. Datasheet
> > +    can be found here:
> > +
> > +https://www.analog.com/media/en/technical-documentation/data-
> sheets/M
> > +AX14001-MAX14002.pdf
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,max14001
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  spi-max-frequency:
> > +    maximum: 5000000
> > +
> > +  vref-supply:
> > +    description: Voltage reference to establish input scaling.
> > +
> > +allOf:
> > +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> 
> Place it like other bindings, so after required or before properties.
> 
> Anyway, what happened with all the properties you had here and should be
> switched to generic ones?

I have decided to remove the properties and utilize the default register values 
during initialization to clear memory validation faults, which I believe is a 
better approach. I am not yet familiar with how to implement some of the 
properties to switch to the userspace ABI, but for now, is it okay to exclude it 
and plan to implement it for future support? 

> 
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    spi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        status = "okay";
> 
> Really... You did not respond to my feedback, so sending uncorrected version
> feels like being ignored. :(

I sincerely apologize, it was an oversight on my part and I didn't mean to 
ignore it, and I understand if it caused any problems. Moving forward, I will ensure 
to thoroughly review and address all feedback provided.

> 
> Best regards,
> Krzysztof