Re: [PATCH v11 07/20] x86/virt/tdx: Add skeleton to enable TDX on demand

From: Dave Hansen
Date: Mon Jun 05 2023 - 19:08:13 EST


On 6/5/23 16:04, Huang, Kai wrote:
> I've changed to -ENODEV which doesn't cause build error in my test.
>
> I agree it's better to include errno.h explicitly but IMHO it's a problem in the
> existing upstream code (tdx_kvm_hypercall() returns -ENODEV when INTEL_TDX_GUEST
> is off), thus should be addressed in a separate patch but not folded into this
> one.
>
> Since now there's no build error, I hesitated to added such patch. I can do it
> separately if it should be addressed.

Yes, it should be addressed.