Re: [PATCH v2 5/5] block: CONFIG_BLK_DEBUG

[Randy Dunlap]

Hi,

On 6/5/23 14:27, Kent Overstreet wrote:
> diff --git a/block/Kconfig b/block/Kconfig
> index 86122e459f..611dddb59c 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -165,6 +165,13 @@ config BLK_CGROUP_IOPRIO
>  	scheduler and block devices process requests. Only some I/O schedulers
>  	and some block devices support I/O priorities.
>  
> +config BLK_DEBUG
> +	bool "Extra block layer assertions"
> +	depends on DEBUG_KERNEL
> +	help
> +	Enable extra assertions in the block layer. Currently this is just the
> +	bio iterator code, but may be expanded.

I see that block/Kconfig isn't consistent about indenting help text,
but Documentation/process/coding-style.rst says:

10) Kconfig configuration files
-------------------------------

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


so please add 2 spaces after the tab at the beginning of the help text
lines (but not the "help" line itself).

-- 
~Randy