Re: [PATCH v8 09/33] x86/cpu: add X86_CR4_FRED macro

[H. Peter Anvin]

On 6/5/23 05:01, Thomas Gleixner wrote:
> On Mon, Apr 10 2023 at 01:14, Xin Li wrote:
>
> > From: "H. Peter Anvin (Intel)" <hpa@xxxxxxxxx>
> >
> > Add X86_CR4_FRED macro for the FRED bit in %cr4. This bit should be a
>
> s/should/must/ no?

Technically no bit "must" be set in the fixed bit variable, but it would 
obviously be insane not to. But it makes it a "should", both in 
dictionary and RFC 2119 definitions.

Incidentally, I strongly advice everyone to use the RFC 2119 definitions 
of technical requirement terms when possible.

	-hpa